Don't trigger monitoring daemons for non standard environments #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
=======================================
Coverage 89.21% 89.21%
=======================================
Files 25 25
Lines 1632 1632
=======================================
Hits 1456 1456
Misses 176 176Continue to review full report at Codecov.
|
|
Is it possible to test this? Doing a quick Google search showed that there are some issues with halting runs for certain environments this way ([0] for example). |
sampierson
approved these changes
Mar 19, 2019
parthshahva
approved these changes
Mar 19, 2019
maniarathi
approved these changes
Mar 20, 2019
maniarathi
pushed a commit
that referenced
this pull request
Mar 29, 2019
* limit cloudwatch rule to default envs * update for pr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested by removing dev from std env list and running make apply in dev env